-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Fix partially the throtteling bug. #607
Conversation
Hi @Cellebyte as mentioned in #603 there is no point in enabling DisableInitialAdminCreation since we use the admin user to create dashboards. The partial solution if minimizing the API calls Is more interesting though. @pb82 have started to look at number of API requests as well so I will let him look at that part. |
I reverted the changes I did to the CRD. |
@NissesSenap is this now ready to merge? |
@Cellebyte i'll give it a try and merge early next week, thanks a lot for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, that makes sense.
Description
Added some minor updates to the CRDs to support the missing
security
flag.I also reduced the api requests.
Relevant issues/tickets
Type of change
I removed the throtteling a little bit by not asking for all
api-resources
in the cluster which are stable.Now I reduced it only to the
apiGroupVersion
which reduces the request amount by huge margin.This should mostly remove the throtteling messages.
Checklist