-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add proposal for ssl specification in Grafana external block #1594
docs: Add proposal for ssl specification in Grafana external block #1594
Conversation
Thanks for this! IMHO this approach is better than #1590. Regarding the proposal - do you see any use case where the certificates & keys live in different secrets? I'd prefer to keep this as simple as possible and think that the use case can be covered by providing a single |
I agree with it. To be honest, I want to use the same mechanism that we use for Grafana credentials because I want to avoid implementing multiple mechanisms to retrieve secrets (and use an existing mechanism). This is why the key name is present multiple times. If you think there could be a better model for this proposal, please let me know. :) |
@theSuess After thinking on the subject, I don't think enforcing the secret type to Here, you get two behaviors:
To ensure these behaviors "The Secret should be of type Opaque or kubernetes.io/tls." because you cannot create a tls type secret if you don't have This behavior is the same with Grafana Alloy's Loki block where the behavior is something similar: https://grafana.com/docs/alloy/latest/reference/components/loki.write/ This means that the proposed block will evolve into something like this: <...>
tls:
certSecretRef: <name of the secret which contains the certificate>
insecureSkipVerify: false
<...> |
Proposal updated to present the validated format from #1594 (comment) |
c8a7a62
to
e4d86c7
Compare
docs/docs/proposals/006-ssl-specification-in-grafanaexternal.md
Outdated
Show resolved
Hide resolved
e4d86c7
to
4dcc3d3
Compare
4dcc3d3
to
54954da
Compare
Aim of the merge request
This MR aims to create a document to propose an evolution on the Grafana CR to permits to give certificate to the Grafana external block.
Breaking change
There is no breaking change because it is just a proposal document. Nothing is implemented yet.
This should be discussed during a maintainer meeting.