-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target for detecting broken links in documentation #1104
Add target for detecting broken links in documentation #1104
Conversation
This is really nice could you add this to be run during CI as well. Maybe a bit painful to run each PR. But it could be something that runs as a cronjob that runs ones a week. Or what do you think? It also seems like there are a few broken links already
Either we try to ignore them in the test, or I guess we fix it. |
I didn't want to add it to CI just yet, because I found while testing that if you bang github too hard, There is a GH action which uses muffet which we can pull in later if we want: |
I would ignore the errors for now, and just fix them on by one. For this one:
That's an example, so won't work anyways. For these ones:
This is related to the values of |
Yeah I think we should shrink the scope and ignore github.com links all together for now. I have did similar things to did in the flux project and there it worked in one of their repos due to the limited links they had in it. But in another repo we had to ignore github.com links due to the rate limiting even happens if you have a github API token it just comes a bit later. |
@rodrigc as described in https://github.com/awsugcz/awsug.cz/blob/main/.github/workflows/periodic-broken-link-checks.yml it seems like all we need to do is to add Do you have time to take a look at the PR again? |
@NissesSenap OK, I added |
This PR hasn't been updated for a while, marking as stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay with a review on this @rodrigc .
LGTM
Solves #956