Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

chore: Auth make it more playwright friendly #141

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

shelldandy
Copy link
Contributor

@shelldandy shelldandy commented Dec 12, 2024

image

Adds a little <Field> component and an inputId to the select dropdown so its easier to locate with playwright on e2e tests

Follows the grafana testing guidelines

@shelldandy shelldandy self-assigned this Dec 12, 2024
This reverts commit e2850f0.
Copy link
Collaborator

@sasklacz sasklacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check the unit tests ? Weird they're not complaining

@shelldandy shelldandy merged commit 3d77ded into main Dec 16, 2024
2 checks passed
@shelldandy shelldandy deleted the chore/auth-select-field branch December 16, 2024 16:43
@shelldandy shelldandy mentioned this pull request Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants