Console instrumentation: send a Faro error for console.error logs #703
+89
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecapitano
force-pushed
the
console-instrumentation-send-error-for-console.error-logs
branch
from
cf63de7 to
6f11ab9
Compare
codecapitano
changed the title
cedricziel
approved these changes
Oct 10, 2024
codecapitano
deleted the
console-instrumentation-send-error-for-console.error-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The console instrumentation sends a log message for each console log level.
For
console.error()logs this behavior oftentimes lead to confusion because users expect it to be send as an error and available in the dedicated errors overviews in Grafana cloud.Faro now sends a error log in case of a console.error message.
What
errorLinks
Checklist