Roll back grpc-go to v1.65.0 because of potential bugs in v1.66.0 #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Revert the grpc-go dependency to v1.65.0 to avoid a potential regression in the latest version. It's not yet clear whether the problem is indeed in grpc-go 1.66.0 or in how loki uses the library, but this allows downstream projects to also downgrade grpc-go without having to pin an older dskit version.
Potentially unrelated to that, it seems like v1.66.0 might have also introduced a performance regression too (grpc/grpc-go#7571), so that's another reason to downgrade.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]