Fixes #49 #52
Merged
Fixes #49 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Schneppenheim <martin.schneppenheim@rewe-digital.com>
tomwilkie
approved these changes
May 6, 2020
pstibrany
approved these changes
May 11, 2020
|
@weeco would you mine rebasing your PR on top of master to fix the merge conflicts? |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…g-comment Fixes grafana/cortex-jsonnet#49 Linting job was not triggered from circleCI. However, this is a small comment only change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Schneppenheim martin.schneppenheim@rewe-digital.com
Thanks for the explanation @gouthamve and @tomwilkie , I thought it's worth to put that as comment right next to the code/config.