Improve compactor alerts and playbooks #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
commented
Jun 21, 2021
|
|
||
| Same as [`CortexCompactorHasNotUploadedBlocks`](#CortexCompactorHasNotUploadedBlocks). | ||
|
|
||
| ### CortexCompactorHasNotSuccessfullyRunCompaction |
There was a problem hiding this comment.
Moved above, to have "Compactor is failing because of not healthy index found" as a sub-section of it.
pracucci
commented
Jun 21, 2021
| @@ -251,18 +261,6 @@ To rename a block stored on GCS you can use the `gsutil` CLI: | |||
| gsutil mv gs://BUCKET/TENANT/BLOCK gs://BUCKET/TENANT/corrupted-BLOCK | |||
| ``` | |||
|
|
|||
| ### CortexCompactorHasNotUploadedBlocksSinceStart | |||
There was a problem hiding this comment.
After the renaming it's covered by CortexCompactorHasNotUploadedBlocks.
pracucci
commented
Jun 21, 2021
|
|
||
| _TODO: this playbook has not been written yet._ | ||
|
|
||
| ### CortexCompactorRunFailed |
There was a problem hiding this comment.
After the renaming it's covered by CortexCompactorHasNotSuccessfullyRunCompaction
pstibrany
approved these changes
Jun 21, 2021
cortex-mixin/docs/playbooks.md
Outdated
| - If the alert `CortexIngesterHasNotShippedBlocks` or `CortexIngesterHasNotShippedBlocksSinceStart` have fired as well, then investigate that issue first | ||
| - Ensure ingesters are successfully shipping blocks to the storage | ||
| - Look for any error in the compactor logs | ||
|
|
||
| ### CortexCompactorHasNotSuccessfullyRunCompaction | ||
|
|
||
| This alert fires if the compactor is not able to successfully run a full compaction. |
There was a problem hiding this comment.
Explain what "full" means? Is it all tenants? Is it all cycles for a single tenant?
There was a problem hiding this comment.
Right. Is it more clear now?
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
playbooks-for-compactor-alerts
branch
from
2538f75 to
11f5495
Compare
pstibrany
approved these changes
Jun 21, 2021
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…for-compactor-alerts Improve compactor alerts and playbooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I'm proposing to cleanup a bit compactor alerts:
CortexCompactorHasNotUploadedBlocksSinceStartintoCortexCompactorHasNotUploadedBlocks. Rationale: no need to distinguish if it's "since start" or not, we just want to alert if a compactor is not uploading blocks.CortexCompactorRunFailedintoCortexCompactorHasNotSuccessfullyRunCompaction. Rationale:CortexCompactorHasNotSuccessfullyRunCompactionis alerting on the case the compactor run is consistently failing, same asCortexCompactorRunFailed, so I think merging makes sense and simplifies.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]