Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default dashboards to Cortex blocks storage only #302

Merged
merged 1 commit into from
May 12, 2021

Conversation

pracucci
Copy link
Collaborator

What this PR does:
With the default config, dashboards both display panels related to Cortex chunks and blocks storage. Given most Cortex users have moved to blocks I propose to change the default to blocks only.

Which issue(s) this PR fixes:
N/A

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci requested a review from a team as a code owner May 11, 2021 17:12
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the default-dashboards-to-blocks-storage branch from fd2f4bf to 1ec012d Compare May 11, 2021 17:15
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the change, but how do we know that "most users have moved to blocks"? Based on issues and Slack, there is still plenty of chunks installations, even new ones since our Helm chart uses that.

@pracucci
Copy link
Collaborator Author

pracucci commented May 12, 2021

I don't mind the change, but how do we know that "most users have moved to blocks"? Based on issues and Slack, there is still plenty of chunks installations, even new ones since our Helm chart uses that.

You're right, we don't have numbers. Let's say then we do this change to push the blocks storage forward :)

@pracucci pracucci merged commit 0b448e9 into main May 12, 2021
@pracucci pracucci deleted the default-dashboards-to-blocks-storage branch May 12, 2021 09:37
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…shboards-to-blocks-storage

Default dashboards to Cortex blocks storage only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants