Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CortexQuerierHighRefetchRate alert #268

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Fixed CortexQuerierHighRefetchRate alert #268

merged 4 commits into from
Mar 12, 2021

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Mar 9, 2021

What this PR does:
Fixing CortexQuerierHighRefetchRate based on what I just learned from @bboreham in #267.

Which issue(s) this PR fixes:
Fixes #267

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

pracucci added 2 commits March 9, 2021 18:09
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from pstibrany March 9, 2021 17:10
@pracucci pracucci requested a review from a team as a code owner March 9, 2021 17:10
@@ -172,7 +172,7 @@
(
sum by(namespace) (rate(cortex_querier_storegateway_refetches_per_query_count[5m]))
-
sum by(namespace) (rate(cortex_querier_storegateway_refetches_per_query_bucket{le="0"}[5m]))
sum by(namespace) (rate(cortex_querier_storegateway_refetches_per_query_bucket{le="0(\\.0)?"}[5m]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean =~ ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant that 🤦 . Anyway, I think changing it to a simpler le="0.0" may be enough.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci merged commit d2c553f into main Mar 12, 2021
@pracucci pracucci deleted the fix-refetch-alert branch March 12, 2021 09:00
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…h-alert

Fixed CortexQuerierHighRefetchRate alert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CortexQuerierHighRefetchRate will not fire
3 participants