Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When we introduced the blocks store support to jsonnet we picked the easiest path: define a
genericBlocksStorageConfig
and set all CLI flags there. These flags were applied to all Cortex services accessing the storage (ingester, querier, ruler, store-gateway, compactor).However, not all flags we set in
genericBlocksStorageConfig
are used by all Cortex services. For example, the flag with prefix-blocks-storage.tsdb.
are ingester specific.In this PR I'm cleaning up the config, setting each CLI flag (related to blocks storage) only to Cortex services that actually use it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]