Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup blocks storage config #257

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Cleanup blocks storage config #257

merged 2 commits into from
Feb 5, 2021

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Feb 5, 2021

What this PR does:
When we introduced the blocks store support to jsonnet we picked the easiest path: define a genericBlocksStorageConfig and set all CLI flags there. These flags were applied to all Cortex services accessing the storage (ingester, querier, ruler, store-gateway, compactor).

However, not all flags we set in genericBlocksStorageConfig are used by all Cortex services. For example, the flag with prefix -blocks-storage.tsdb. are ingester specific.

In this PR I'm cleaning up the config, setting each CLI flag (related to blocks storage) only to Cortex services that actually use it.

Which issue(s) this PR fixes:
N/A

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner February 5, 2021 08:58
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$._config.queryBlocksStorageConfig, $.blocks_metadata_caching_config and $.bucket_index_config seem to be always used together. Maybe the latter two could be merged into first one?

@pracucci
Copy link
Collaborator Author

pracucci commented Feb 5, 2021

$._config.queryBlocksStorageConfig, $.blocks_metadata_caching_config and $.bucket_index_config seem to be always used together. Maybe the latter two could be merged into first one?

Ok. Let me do it in a separate PR.

@pracucci pracucci merged commit ea33cb1 into master Feb 5, 2021
@pracucci pracucci deleted the cleanup-blocks-storage branch February 5, 2021 09:06
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
…ocks-storage

Cleanup blocks storage config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants