Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable multi-selection for variables in resources dashboards. #251

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Jan 19, 2021

What this PR does: This PR disables multi-selection of cluster and namespace variable in resources dashboards.

I think we should do it in all dashboards, but this conservative PR is a first step to see what others think about it.

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pstibrany pstibrany requested a review from a team as a code owner January 19, 2021 07:42
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In resources dashboards make a lot of sense to me. Don't have a strong opinion about other dashboards tho.

@pstibrany
Copy link
Member Author

My reason is that I usually (99%) want to see dashboards for a single namespace, but the way Grafana works, I always need to do couple of clicks to get to the correct state.

@pstibrany pstibrany merged commit b9814fe into master Jan 20, 2021
@pstibrany pstibrany deleted the disable-multi-selection-in-resources-dashboards branch January 20, 2021 11:22
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…na/cortex-jsonnet#251)

* Disable multi-selection for variables in resources dashboards.

* CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants