Fixed workingset memory panel while rolling out a StatefulSet #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…-panels Fixed workingset memory panel while rolling out a StatefulSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Everytime we rollout ingesters, I see this worrying trend:
Today I've investigated it and it turned out to be a false positive. The problem is that during the rollout of a statefulset we have duplicated series, both the old pod and the new pod (even if the pod ID is the same, the metric have other labels which are distinct).
In the following panel, on the left you can see
sum by(pod)while on the right you can see the 2 series:This PR should fix it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]