Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses $__rate_interval in ruler dashboard queries #224

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Dec 4, 2020

Using the $__interval along with rate/increase queries can leave undesirably blank dashboards in some cases. As per https://grafana.com/docs/grafana/latest/datasources/prometheus/#using-__rate_interval-variable, we should use $__rate_interval instead.

Before:
image

After:
image

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner December 4, 2020 19:07
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We're using $__interval with rate() in other dashboards too. Do you mind opening a PR for that too, please?

@owen-d owen-d mentioned this pull request Dec 4, 2020
@owen-d owen-d merged commit 9071fd2 into grafana:master Dec 7, 2020
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…interval

Uses $__rate_interval in ruler dashboard queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants