Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alert for failed compator run. #206

Merged
merged 5 commits into from
Nov 10, 2020
Merged

Added alert for failed compator run. #206

merged 5 commits into from
Nov 10, 2020

Conversation

pstibrany
Copy link
Member

What this PR does: This PR adds new alert for failed compactor run.

@pstibrany pstibrany requested a review from a team as a code owner October 27, 2020 11:53
increase(cortex_compactor_runs_failed_total[10m]) > 0
|||,
labels: {
severity: 'warning',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are generally ignored. Can we remove potential noise from the alert and make it a critical one?

For example, assuming there's some work to do at least every 2h, we could have a critical alert like this:

  • expr: increase(cortex_compactor_runs_failed_total{cluster="us-central1"}[3h]) > 0
  • for: 2h

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on offline discussion.

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pracucci pracucci merged commit 3eb2d42 into master Nov 10, 2020
@pracucci pracucci deleted the compactor-alert branch November 10, 2020 14:58
simonswine pushed a commit to grafana/mimir that referenced this pull request Oct 18, 2021
…alert

Added alert for failed compator run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants