Add the ruler to the read resources dashboard #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstyan
approved these changes
Oct 17, 2020
|
I think its more read than write. The whole point of rules is to query large amounts of data and then distill it into small amounts of data. I would say it adds substantatively to read rather than write. |
gotjosh
changed the title
|
good shout @gouthamve |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…urces Add the ruler to the read resources dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds the ruler to the write resources dashboard. Technically the ruler is both a read/write resources but it felt more compelling to the add the write than the read.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]