feat: use querier specific API metrics #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
simonswine
approved these changes
Oct 12, 2020
|
@simonswine In single-binary mode we don't register the querier handler using external HTTP routes. Those routes are registered for the query-frontend instead. The querier is registered on a secondary router that we pass requests to after they are processed by the query frontend and scheduled. This router has a separate set of latency metrics prefixed |
pracucci
approved these changes
Oct 13, 2020
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…uerier_api_metrics feat: use querier specific API metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
When running using a single binary the query-frontend API metrics will supersede the queriers for the same route. A separate set of latency metrics exist for the querier. This PR ensures those metrics are used by the Cortex read dashboard.