Block Storage Support for S3/AWS #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestsword
force-pushed
the
s3-tsdb-support
branch
from
2296aa6 to
52443ab
Compare
pracucci
approved these changes
Sep 21, 2020
1 task
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…b-support Block Storage Support for S3/AWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the setting
blocks_storage_backendto allow switching between gcs and s3 for block storage. Feel free to critique the way I implemented it in jsonnet. Everyone has an opinion but I appreciate here that if I want to use azure I wouldn't need to add code here I could just add togenericBlocksStorageConfigand move on.Closes #140, I tried to wait for it to complete. Fixes #166.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]