Fix typo in Alertmanager configuration and more tweaks #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
changed the title
gotjosh
force-pushed
the
fix-am
branch
4 times, most recently
from
fbbb58b to
97a290d
Compare
- Introduces the `fallback_config` option to allow an Alertmanager to have a fallback config. - Given the headless service a different name to allow seamless switching between 1 or multiple replicas. The cluster field in the service metadata is immutable which made it impossible to create the new service unless you delete the previous one.
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
Fix typo in Alertmanager configuration and more tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three main things for our Alertmanager configuration:
alertmanger.gossip_portinstead ofalertmanager_gossip_portfallback_configto allow a fallback configuration to be specified.headless-service. TheClusterIPmetadata field is immutable so we can't really update the spec of the service which makes it hard to switch between 1 and multiple replicas.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]