Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnableTLS config #63

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

tiagorossig
Copy link
Contributor

@tiagorossig tiagorossig commented Sep 20, 2024

This PR exposes the node config required to enable HTTPS in the transport used for gossiping.

This is a dependency for grafana/alloy#1724, which fixes grafana/alloy#367.

Why is this change required

My organization runs alloy pods in environments that require all pod communications over HTTPS and require TLS encryption. When enabling clustering, we noticed that communication between pods was blocked because it was going over HTTP.

Copy link

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattdurham
Copy link

This looks reasonable to me, @tpaschalis thoughts?

@mattdurham mattdurham merged commit ee13448 into grafana:main Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow: Support TLS client settings for clustering
2 participants