Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-behalf-of token provider using configurable middleware #542

Merged
merged 7 commits into from
Feb 1, 2023

Conversation

kostrse
Copy link
Contributor

@kostrse kostrse commented Jan 18, 2023

The on-behalf-of authentication was reimplemented in a form of aztokenprovider.AzureTokenProvider so it could be registered in authentication middleware.

Based on the new implementation of configurable authentication middleware in the Grafana Azure SDK:

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here make sense, once we agree on the SDK interface.

pkg/azuredx/datasource.go Show resolved Hide resolved
@kostrse kostrse marked this pull request as ready for review February 1, 2023 12:31
@kostrse kostrse requested a review from a team as a code owner February 1, 2023 12:31
@kostrse kostrse requested review from bossinc and aangelisc February 1, 2023 12:31
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @kostrse 👍

@aangelisc aangelisc merged commit 683000d into grafana:main Feb 1, 2023
@kostrse kostrse deleted the auth-obo-token-provider branch February 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants