Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generic HTTP settings for Azure cloud endpoints #554

Closed
kostrse opened this issue Jan 31, 2023 · 2 comments
Closed

Ignore generic HTTP settings for Azure cloud endpoints #554

kostrse opened this issue Jan 31, 2023 · 2 comments

Comments

@kostrse
Copy link
Contributor

kostrse commented Jan 31, 2023

instanceSettings.HTTPClientOptions() allow to inherit generic HTTP settings for datasource.
While this features allows user to customize authentication and HTTP request, it should not be used for Azure cloud endpoints.

Cloud endpoints have predefined set of capabilities/authentication methods which can be supported by the datasource and user should not customize HTTP requests to Azure endpoints.

@aangelisc
Copy link
Contributor

Hi @kostrse, the default HTTPClientOptions() also sets various defaults on the HTTP client utilised in datasources and ensures various settings are standardised.

I appreciate that users shouldn't modify requests to the Azure endpoints, however if a user were to customise the request I'm sure the additional headers would be ignored by the Azure endpoints? Please correct me if I'm wrong on this. Otherwise, we will not be removing the default HTTP client settings.

@aangelisc aangelisc removed the type/bug Something isn't working label Feb 23, 2023
@aangelisc aangelisc moved this from Incoming to Waiting in Partner Datasources Feb 23, 2023
@aangelisc
Copy link
Contributor

As mentioned we'd need the HTTPClientOptions to remain as they're used to configure internal middlewares and functionality. Closing this and if it's still an issue we can pick this up offline and discuss a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants