Update from upstream (take 2) #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et in the Command Line
Signed-off-by: Andrei Pangin <1749416+apangin@users.noreply.github.com>
…WallClockSample for Wall clock profiling
…events are unavailable
…vents if kernel profiling is unavailable
…tin_frame_address
|
|
marcsanmi
approved these changes
Nov 26, 2024
| @@ -1,30 +1,58 @@ | |||
| PROFILER_VERSION=3.0.0.0 | |||
| PROFILER_VERSION ?= 3.0.0.1 | |||
There was a problem hiding this comment.
To not forget: Change this back in case we decide not to bump.
aleks-p
commented
Nov 26, 2024
| long time = getVarlong(); | ||
| int tid = getVarint(); | ||
| int stackTraceId = getVarint(); | ||
| int threadState = getVarint(); | ||
| return new ExecutionSample(time, tid, stackTraceId, threadState); | ||
| getVarint(); // contextId |
There was a problem hiding this comment.
This is a manual addition and JFR conversion doesn't work without this. AFAIK in the current usage of the library this only affects tests, Pyroscope uses https://github.com/grafana/jfr-parser to ingest JFR files which does the same.
@korniltsev fyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #3 but with a fix for the new tests (
AllocTestswas hanging) and without the GitHub action changes.