docs: temporarily remove boringcrypto references #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes boringcrypto references until #64 is resolved.
|
We could use a specific string in all commented text blocks. For example something like this: Then later, we can grep for that partial string and make a go/no-go call on the hidden content |
clayton-cornell
added
the
type/docs
@clayton-cornell In this particular case the content definitely will be removed until 1.1, since we won't have boringcrypto back in place until then. |
|
@rfratto This one stalled out? |
|
Updating to merge now; instead of the comments I'll just remove the irrelevant information and link to this PR in #64 so it can be reverted once boringcrypto support returns |
rfratto
added
the
backport-to-agent:no
rfratto
added a commit
to rfratto/alloy
that referenced
this pull request
Apr 30, 2024
This reverts commit c9daa54.
rfratto
added a commit
to rfratto/alloy
that referenced
this pull request
Apr 30, 2024
This reverts commit c9daa54.
rfratto
added a commit
to rfratto/alloy
that referenced
this pull request
Apr 30, 2024
This reverts commit c9daa54.
rfratto
added a commit
that referenced
this pull request
May 1, 2024
* misc: build boringcrypto and cngcrypto images for Linux and Windows * docs: document boringcrypto images * Revert "docs: temporarily remove boringcrypto references (#97)" This reverts commit c9daa54. * Apply suggestions from code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * docs: use BoringCrypto/CNGCrypto as proper spelling --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
polyrain
pushed a commit
to polyrain/alloy
that referenced
this pull request
May 2, 2024
* misc: build boringcrypto and cngcrypto images for Linux and Windows * docs: document boringcrypto images * Revert "docs: temporarily remove boringcrypto references (grafana#97)" This reverts commit c9daa54. * Apply suggestions from code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * docs: use BoringCrypto/CNGCrypto as proper spelling --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes boringcrypto references until #64 is resolved.
cc @clayton-cornell I'm not sure if commenting out the old blocks was the best move here, but I'm a little worried we'll forget all the places where it was mentioned if I removed them outright. WDYT? I could just link to this PR from #64 instead of commenting things out.