Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.java: Add glibc detection for arm64 #661

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 24, 2024

This PR makes sure glibc is also detected correctly on ARM64 linux.

@simonswine simonswine changed the title Add glibc detection for arm64 pyroscope.java: Add glibc detection for arm64 Apr 24, 2024
@simonswine simonswine added the bug Something isn't working label Apr 24, 2024
@simonswine simonswine marked this pull request as ready for review April 24, 2024 13:43
@simonswine simonswine added the backport-to-agent PR should be backported to the agent repo. label Apr 24, 2024
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert at this part of the codebase, but LGTM

@tpaschalis tpaschalis merged commit 87374ea into main Apr 25, 2024
15 checks passed
@tpaschalis tpaschalis deleted the 20240424_fix-glibc-detection-arm64 branch April 25, 2024 07:42
hainenber pushed a commit to hainenber/alloy that referenced this pull request May 1, 2024
simonswine added a commit to simonswine/grafana-agent that referenced this pull request May 13, 2024
ptodev pushed a commit to grafana/agent that referenced this pull request May 15, 2024
@simonswine simonswine added backport-to-agent:done PR has been backported to the agent repo and merged. and removed backport-to-agent PR should be backported to the agent repo. labels May 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-agent:done PR has been backported to the agent repo and merged. bug Something isn't working frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants