tools: fix incompatibilities between normal and alpine sh #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sh` (as executed by Alpine) understands `set -o pipefail`, but other installations of sh do not. This commit partially reverts the change from #640 so that the scripts expect bash, and that our usage of alpine installs bash before executing the tools/image-tag-docker script.
rfratto
added
the
backport-to-agent:no
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
`sh` (as executed by Alpine) understands `set -o pipefail`, but other installations of sh do not. This commit partially reverts the change from grafana#640 so that the scripts expect bash, and that our usage of alpine installs bash before executing the tools/image-tag-docker script.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sh(as executed by Alpine) understandsset -o pipefail, but other installations of sh do not.This commit partially reverts the change from #640 so that the scripts expect bash, and that our usage of alpine installs bash before executing the tools/image-tag-docker script.