Fix OTEL alerts query #1818
Merged
Fix OTEL alerts query #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
force-pushed
the
thampiotr/fix-otel-alert-query
branch
from
abfea5b
to
b0af58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is a fix to yet unreleased change to OTEL alerts queries that was added in this PR: #1721
There was a mistake in original PR: we were calculating the failure rate of each time series and then doing
sum by (cluster, namespace, job)on these, so if we had 200 instances with 1% failure rate, we would end up with 200% failure rate.Instead we should
sum by (cluster, namespace, job)for the nominator (number of failures) and the denominator (total number of events) to get a correct SR for the entire cluster/namespace/job.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist