Add info about end of line character in loki.source.file #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
type/docs
wildum
approved these changes
Sep 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 6581efd)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 6581efd)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 6581efd)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 6581efd)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 6581efd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds a sentence clarifying that log lines are not forwarded until an end of line character is found.
Which issue(s) this PR fixes
Fixes #1678
Notes to the Reviewer
PR Checklist