feat: Add Secret Filtering component #1593
Conversation
|
|
romain-gaillard
changed the title
romain-gaillard
requested review from
clayton-cornell and
a team
as code owners
| // | ||
| // For the first case, we can replace the entire match with the redaction string. | ||
| // For the second case, we can replace the first submatch with the redaction string (to avoid redacting something else than the secret such as delimiters). | ||
| for _, occ := range r.regex.FindAllStringSubmatch(entry.Line, -1) { |
There was a problem hiding this comment.
Think we can split this block into a separate func, lots of deep nesting going on.
There was a problem hiding this comment.
Changed in d8fa6e5.
clayton-cornell
added
the
type/docs
Thanks a lot! I addressed your suggestions in 500891f 😄 |
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
romain-gaillard
force-pushed
the
secret-filtering
branch
from
567c920
to
b537c85
Compare
Done, thanks. We've done basic benchmarks and found that the overhead for redaction is less than a ms per log entry on a standard laptop, with all secrets enabled. Right now, our focus is to get it merged so that we can start to use it to redact secrets internally for security purposes. |
PR Description
This PR adds a secret filtering component for Loki into Alloy. It is based on the work we have done in the August 2024 hackathon.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist