-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: analysis radical migration tool #388
Conversation
ToDo:
|
ready for review! |
src/kimmdy/analysis.py
Outdated
|
||
parser_radical_migration = subparsers.add_parser( | ||
name="radical_migration", | ||
help="Create a csv of radical migration events for further analysis.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json, not csv, right?
I don't want to write the tutorial now but the rest has been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you want users to run the script? Right now it would be something like python -m kimmdy.assets.scripts.analyse_kimmdy_migration.py
, in which case you would want to add the classic if __name__ == "__main__"
thing. Though from the # %%
comments it looks more like something you expect people to run interactively in their own environment, so I'm wondering if some place in the guide
docs folder would be a better solution, to separate it from the regular kimmdy modules. Also, do you want to add pymol
to https://github.com/hits-mbm-dev/kimmdy/blob/0bc5a68b7adbd026a7a7cd78176a2d47b602dc68/setup.cfg#L60-L72 ?
I would say installing pymol is a bit messy, so I would leave it to the user. |
this tool will create a json file of migrations which can be visualized in pymol using an external script