Play 2.8 support #163
Play 2.8 support #163
Conversation
Play's 2.8 changelog does not mention much actually needing to change from the build pipeline perspective, so an easy string replacement for the integration test fixtures to verify and test should be enough to verify. Based on the previous PR from #133, this expands the changes to ensure the integration tests pass as well. Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
… java-forms. Forked from branch "gabizou:play-2.8" following PR "#154" Signed-off-by: iacopo.pace <iacopo.pace@yahoo.it>
|
@JLLeitschuh let me know if there's anything else I need to do to start with this review, first time contributing to the project for me :) |
|
It looks like this is indeed passing all the tests. Really nice work! I'm going to give some others an opportunity to review/provide feedback. I'll merge this Tuesday if I don't hear any other concerns. |
|
@JLLeitschuh I was able to build and test the updated plugin from my branch with a project running the latest play 2.8.7 and it worked fine! |
|
@JLLeitschuh any chance this can be merged this week? |
|
@big-guy has asked us to hold off on merging this change until after 7.0 is released. |
Hi @JLLeitschuh, I would love to see a minor version of the project released even before that if it does not create too much work. I am looking at migrating a project to Play 2.8.7 from 2.7.9 since we are about end of life (https://discuss.lightbend.com/t/end-of-support-roadmap/7619/2) and to also take care of some dependencies (like some of the jackson libs) and their CVEs without resorting to manually forcing versions. |
|
@JLLeitschuh @big-guy same problem here - is there an ETA that you could share for when this could be merged? We are not planning to upgrade to gradle 7 anytime soon, and am worried, if this plugin turns out to be incompatible with gradle 7, this change will end up not being merged and we'll have to find a workaround to update to play 2.8.x. Thanks! |
|
I see no issues merging this. I'm fully in support of moving this forward. |
|
@iaco86 thank you so much for finally pushing this over the finish line. I really appreciate it! |
|
@JLLeitschuh No problem! I'm glad I could help - thanks for maintaining support despite this being a not-so-popular plugin. |
|
@JLLeitschuh any play to release this? :) |
Following #154:
play-java-formssupport to 2.8.x inPlayApplicationPluginPlayTwirlAdapterV28Xbased on Play 2.8 TemplateImports.javaTests seem to be passing locally.