Misc build logic improvements #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshevche
force-pushed
the
pshevche/simplify-build-logic
branch
from
dae7252
to
5b909ed
Compare
pshevche
force-pushed
the
pshevche/add-documentation
branch
from
b868bfd
to
ca57a6f
Compare
pshevche
force-pushed
the
pshevche/simplify-build-logic
branch
from
5b909ed
to
c021b41
Compare
leonard84
approved these changes
Mar 14, 2024
Comment on lines
+17
to
+27
| sourceSets { | ||
| create("compatibilityApi") | ||
| create("enterpriseCompatibility") | ||
| create("develocityCompatibility") | ||
| } | ||
|
|
||
| tasks.jar { | ||
| from(sourceSetOutput("compatibilityApi")) | ||
| from(sourceSetOutput("enterpriseCompatibility")) | ||
| from(sourceSetOutput("develocityCompatibility")) | ||
| } |
There was a problem hiding this comment.
Can't you use something like this?
val compatibilityApi by sourceSets.creating
///...
tasks.jar {
from(compatibilityApi.output)
There was a problem hiding this comment.
Yes, I can. But I prefer that the plugin uses the same notation as its consumers (i.e., sourceSetOutput extension function).
snoopcheri
approved these changes
Mar 15, 2024
jean-andre-gauthier
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.