Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc build logic improvements #5

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Conversation

pshevche
Copy link
Member

No description provided.

@pshevche pshevche self-assigned this Mar 14, 2024
@pshevche pshevche force-pushed the pshevche/simplify-build-logic branch from dae7252 to 5b909ed Compare March 14, 2024 14:33
@pshevche pshevche force-pushed the pshevche/simplify-build-logic branch from 5b909ed to c021b41 Compare March 14, 2024 14:38
.github/workflows/verify.yml Outdated Show resolved Hide resolved
Comment on lines +17 to +27
sourceSets {
create("compatibilityApi")
create("enterpriseCompatibility")
create("develocityCompatibility")
}

tasks.jar {
from(sourceSetOutput("compatibilityApi"))
from(sourceSetOutput("enterpriseCompatibility"))
from(sourceSetOutput("develocityCompatibility"))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you use something like this?

val compatibilityApi by sourceSets.creating
///...
tasks.jar {
    from(compatibilityApi.output)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can. But I prefer that the plugin uses the same notation as its consumers (i.e., sourceSetOutput extension function).

Base automatically changed from pshevche/add-documentation to main March 18, 2024 10:10
@pshevche pshevche merged commit eb711a4 into main Mar 18, 2024
3 checks passed
@pshevche pshevche deleted the pshevche/simplify-build-logic branch March 18, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants