Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more docs for using components in chatbot #8593

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Adding more docs for using components in chatbot #8593

merged 7 commits into from
Jun 21, 2024

Conversation

abidlabs
Copy link
Member

No description provided.

@abidlabs abidlabs requested a review from aliabd June 21, 2024 17:11
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 21, 2024 •
edited
Loading

🪼 branch checks and previews

• Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/5b0422f8e3e6d2cba1d0aa64081326e7e0c32bd5/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@5b0422f8e3e6d2cba1d0aa64081326e7e0c32bd5#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/5b0422f8e3e6d2cba1d0aa64081326e7e0c32bd5/gradio-client-1.1.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 21, 2024 •
edited
Loading

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
website patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Adding more docs for using components in chatbot

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?
  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jun 21, 2024
aliabd
aliabd reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @abidlabs

gradio/components/chatbot.py Outdated
@@ -62,7 +62,7 @@ class Chatbot(Component):
Also supports audio/video/image files, which are displayed in the Chatbot, and other kinds of files which are displayed as links. This
component is usually used as an output component.

Demos: chatbot_simple, chatbot_multimodal
Demos: chatbot_simple, chatbot_multimodal, chatbot_core_components
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't currently support demos with any requirements on the docs, I can add support for it soon. But remove this for now as its erroring out on lite.

aliabd
aliabd approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry meant to approve

@abidlabs
Copy link
Member Author

Ah good catch. I'll make a simplified version of this demo without dependencies. Just to be clear, the problem is plotly, or is it the files?

@aliabd
Copy link
Collaborator

aliabd commented Jun 21, 2024

Oh the files might be an issue as well, there are workarounds. But there's also another problem that we only used the release version of lite on the website, so this wouldn't work anyways until after release. I would just remove the demo for now and I can add it after.

Or actually you could just embed it from spaces directly into the svx? Like just add the demo under the the new examples section.

@abidlabs
Copy link
Member Author

The new demo I'm using (chatbot_core_components_simple) should be fine, right? It has no external dependences or files.

@aliabd
Copy link
Collaborator

aliabd commented Jun 21, 2024

@abidlabs yeah it will work. but only on release when lite gets updated. I think this is good for now

I'll open a PR to start using main wheel of lite on /main

@abidlabs abidlabs enabled auto-merge (squash) June 21, 2024 17:57
@abidlabs abidlabs merged commit d35c290 into main Jun 21, 2024
7 of 8 checks passed
@abidlabs abidlabs deleted the chatbot-component-docs branch June 21, 2024 18:04
This was referenced Jun 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabd aliabd aliabd approved these changes

Assignees
No one assigned
Labels
v: patch A change that requires a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abidlabs @gradio-pr-bot @aliabd