-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to disable orange progress animation for generators #8543
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/d16c5c4abdd502ce459845e32b58a01420c767ba/gradio-4.36.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d16c5c4abdd502ce459845e32b58a01420c767ba#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/d16c5c4abdd502ce459845e32b58a01420c767ba/gradio-client-1.1.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks! technically a visual breaking change but pretty minor
@@ -732,6 +735,9 @@ async def cleanup(): | |||
batch=self.batch, | |||
max_batch_size=self.max_batch_size, | |||
concurrency_limit=self.concurrency_limit, | |||
show_progress=cast( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is a cast necessary? isn't show_progress set to be of type Literal["full", "minimal", "hidden"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyright infers it as str
instead of the narrower Literal
so it complains. I think it's because the property is set in init but it's being used in a separate method here.
Update changelog
Thanks for the review @aliabid94 ! |
Description
The orange animation is always displayed for a generator. You may want to disable this. For example, in a chatbot demo where the text stream is enough indication that progress is being made. In this PR, the orange animation is only shown for generators if
show_progress='full'
. Also addedshow_progress
forInterface
andChatInterface
.I thought there was an issue for this but I can't find it.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh