Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Upload Button #3782

Merged
merged 6 commits into from
Apr 10, 2023
Merged

Fix Upload Button #3782

merged 6 commits into from
Apr 10, 2023

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Apr 6, 2023

Description

The upload button was not properly handling the case of multiple files. Going to test in colab once the PR wheel gets built.

Closes: #3729, Closes: #3790

Edit: Works in colab!

upload_colab

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

A note about the CHANGELOG

Hello 👋 and thank you for contributing to Gradio!

All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.

Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.

@gradio-pr-bot
Copy link
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3782-all-demos

@freddyaboulton freddyaboulton marked this pull request as ready for review April 6, 2023 23:31
@freddyaboulton freddyaboulton requested review from aliabid94, pngwn and dawoodkhan82 and removed request for aliabid94 April 6, 2023 23:31
@freddyaboulton freddyaboulton self-assigned this Apr 10, 2023
Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works

@freddyaboulton
Copy link
Collaborator Author

Thanks so much @dawoodkhan82 !

@freddyaboulton freddyaboulton merged commit ad50eaa into main Apr 10, 2023
@freddyaboulton freddyaboulton deleted the fix-upload-btn branch April 10, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants