Google Analytics fix #3349
Merged
Google Analytics fix #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abidlabs
commented
Mar 1, 2023
| @@ -585,7 +585,7 @@ def iterate_over_children(children_list): | |||
|
|
|||
| derived_fields = ["types"] | |||
|
|
|||
| with Blocks(theme=config["theme"], css=config["theme"]) as blocks: | |||
There was a problem hiding this comment.
Unrelated, but noticed that this issue as well
abidlabs
requested review from
dawoodkhan82,
freddyaboulton,
pngwn and
aliabid94
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3349-all-demos |
freddyaboulton
approved these changes
Mar 1, 2023
|
Thanks for reviewing @freddyaboulton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that in the front end,
analytics_enabledwas always hardcoded to beFalse, which meant that Google analytics were never called. This fixes that so that we have more reliable usage analytics.