Fix auth when connecting via HTTP #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3223-all-demos |
|
Nice! Can confirm both links work for me, both in incognito and regular browsing mode. Shall we include this in |
|
Yes! Just modified the CHANGELOG and got rid of some of the code that was added in a separate branch I had lol |
freddyaboulton
requested review from
aliabid94,
abidlabs,
aliabd,
dawoodkhan82 and
pngwn
|
Tested locally as well, works beautifully! |
abidlabs
approved these changes
Feb 17, 2023
|
@aliabid94 @dawoodkhan82 Can you give the |
|
Frontend LGTM! |
|
Thanks for the review!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an unsecured token that can be set/sent via HTTP. Also removing
__gradio_loader__as that breaks auth on main, see: https://huggingface.slack.com/archives/C02SPHC1KD1/p1676671390297609?thread_ts=1676591517.723239&cid=C02SPHC1KD1Fixes #3171
Login spaces still works, test here: https://huggingface.co/spaces/freddyaboulton/hello_login_main
Login via http now works, test here: http://ec2-54-144-135-68.compute-1.amazonaws.com:7860/
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.