Check file_types is a list #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3048-all-demos |
abidlabs
reviewed
Jan 24, 2023
| @@ -2250,6 +2250,10 @@ def __init__( | |||
| """ | |||
| self.file_count = file_count | |||
| self.file_types = file_types | |||
| if file_types is not None and not isinstance(file_types, list): | |||
| raise ValueError( | |||
| f"Parameter file_types must be a list. Received {file_types.__class__.__name__}" | |||
There was a problem hiding this comment.
Did not know you could do .__class__ on primitives, nice!
|
Thanks @freddyaboulton, this looks good! Can you also add this logic to |
freddyaboulton
force-pushed
the
3043-file-types-check
branch
from
b7c8560 to
ffca579
Compare
|
@abidlabs - good point! Just added that logic to UploadButton! |
abidlabs
approved these changes
Jan 25, 2023
|
Thank you for the review @abidlabs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3043
As noted in #3043, if
file_typesis not a list, the app will crash. Raising an error on the back-end to check that parameter is a list!Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.