-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download button to model3d output #3014
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3014-all-demos |
🎉 The demo notebooks match the run.py files! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great @dawoodkhan82 !
Just wondering if we should consolidate the download utils between File and model3d
@@ -0,0 +1,38 @@ | |||
import type { FileData } from "@gradio/upload"; | |||
|
|||
export const prettyBytes = (bytes: number): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be the same code as in file/src/utils.ts
- should we consolidate?
Yup will def do that and add it to this PR. Was also thinking of adding a download button to other components (video, audio etc.) |
Nice @dawoodkhan82! Nit: the alignment with the top left label is off. What do think about making it the same level as the "3D Model" label on the top left, i.e. have the button be stuck on the top right corner? Similar to the copy button in the JSON component: |
I could do that, but I was actually mimicking the position of the 'x' button used to clear an input. |
Got it, that makes sense too. Nvm my suggestion then |
In that case, maybe we should change "copy to clipboard" in JSON component to be a copy icon in the same size/position as these other ones (at some point, not urgent) |
|
Hmm seems a little crowded. I thought clicking on the filename already allowed you to download the file? |
There was text labeled |
Oh sorry yeah I think we can do that outside of this PR |
@freddyaboulton not sure why the notebook check is failing... |
@dawoodkhan82 One of the demo files got changed but the notebook was not updated in this PR. I think the generate_notebook.py script should fix it ? |
Description
Add download button to model3d output
![Screenshot 2023-01-18 at 3 52 45 PM](https://user-images.githubusercontent.com/12725292/213294135-9d4c476d-66d6-46fd-8be7-14bfa3f3d077.png)
Please include:
Closes: #3001
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.