-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button default name #1243
Button default name #1243
Conversation
- fix&update gr.component - create a demo introducing shortcuts within Blocks
- tweaks
- tweaks
- fix formatting
- tweaks - fix tests
- tweaks - fix tests
- tweaks - fix tests
- add a default name in Button
- add a default name in Button
I think "Run" is a reasonable default, although the sole puprose of this button is to render some text, I don't think asking users to pass in a value is unreasonable. I'd be happy with either the default or making it required. |
I think it makes more sense as a required param (so buttons always get the right wording), but no super strong opinion on it. |
Lets make it required then, seems reasonable. |
If there is no strong opinion on this I would suggest we continue with default values. Check demo |
The string shortcut is a good point. Lets merge this. |
Description
Add a default button name since it was not looking good in default.
Before:
![image](https://user-images.githubusercontent.com/44067394/168231364-e00b3d77-b192-4777-b2a6-b104ad1a8a11.png)
Now:
![image](https://user-images.githubusercontent.com/44067394/168231098-63f2f02c-a907-49b4-b547-36873ec222b0.png)