Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-shortcut-syntax #1234

Merged
merged 7 commits into from
May 13, 2022
Merged

update-shortcut-syntax #1234

merged 7 commits into from
May 13, 2022

Conversation

omerXfaruq
Copy link
Contributor

@omerXfaruq omerXfaruq commented May 12, 2022

  • fix&update gr.component
  • create a demo introducing shortcuts within Blocks

gr.component()'s functionality was changed and lost its main purpose, it was returning classes instead of objects, return that functionality back.

- fix&update gr.component
- create a demo introducing shortcuts within Blocks
@omerXfaruq omerXfaruq requested review from radames and abidlabs May 12, 2022 19:14
Copy link
Contributor

@radames radames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks cool to me! thanks for the new demo, I guess it now makes more sense.

Comment on lines 15 to 21
with gr.Row():
with gr.Column():
text1 = gr.component("textarea")
with gr.Column():
text2 = gr.TextArea()
with gr.Column():
text3 = gr.templates.TextArea()
Copy link
Member

@pngwn pngwn May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would having these components at the top level achieve the same layout?

- tweaks
- fix tests
- tweaks
- fix tests
- tweaks
- fix tests
@omerXfaruq omerXfaruq merged commit 2de9ee8 into main May 13, 2022
@omerXfaruq omerXfaruq deleted the update-shortcut-syntax branch May 13, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants