Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use secondary buttons in interface #1173

Merged
merged 2 commits into from
May 7, 2022
Merged

use secondary buttons in interface #1173

merged 2 commits into from
May 7, 2022

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented May 6, 2022

Description

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Closes: # (issue)

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pngwn pngwn requested a review from abidlabs May 6, 2022 11:29
@pngwn pngwn mentioned this pull request May 6, 2022
Closed
31 tasks
@pngwn pngwn requested a review from aliabid94 May 6, 2022 17:12
@abidlabs
Copy link
Member

abidlabs commented May 6, 2022

Looks great!

@pngwn pngwn merged commit b8fb0b4 into main May 7, 2022
@pngwn pngwn deleted the secondary-button branch May 7, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abidlabs abidlabs abidlabs approved these changes

@aliabid94 aliabid94 Awaiting requested review from aliabid94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pngwn @abidlabs