Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flagging fixes #1081

Merged
merged 9 commits into from
Apr 27, 2022
Merged

Flagging fixes #1081

merged 9 commits into from
Apr 27, 2022

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Apr 25, 2022 •
edited
Loading

This PR fixes a few things currently broken with flagging:

@abidlabs abidlabs marked this pull request as ready for review April 26, 2022 00:05
@abidlabs
Copy link
Member Author

Ready to be reviewed @farukozderim @aliabid94

omerXfaruq
omerXfaruq reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@omerXfaruq omerXfaruq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT other than the above points

gradio/interface.py Show resolved Hide resolved
gradio/routes.py Show resolved Hide resolved
@abidlabs
Copy link
Member Author

Thanks @farukozderim for the review. Have added the response validation back

@abidlabs abidlabs merged commit 82e95e2 into main Apr 27, 2022
@abidlabs abidlabs deleted the flagging-fixes branch April 27, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerXfaruq omerXfaruq omerXfaruq left review comments

@aliabid94 aliabid94 Awaiting requested review from aliabid94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow_flagging="never" doesn't disable Flag Button HF Callback not working with Urdu Text
2 participants
@abidlabs @omerXfaruq