Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZeroGPU] Handshake-based postMessage #10270

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Conversation

cbensimon
Copy link
Contributor

No description provided.

@abidlabs abidlabs requested a review from pngwn December 31, 2024 17:35
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Dec 31, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/7deb6895420b0562cdcae3aa735cd462e9c0207e/gradio-5.11.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@7deb6895420b0562cdcae3aa735cd462e9c0207e#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/7deb6895420b0562cdcae3aa735cd462e9c0207e/gradio-client-1.9.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/7deb6895420b0562cdcae3aa735cd462e9c0207e/dist/lite.js""></script>

@cbensimon
Copy link
Contributor Author

Working as expected in this Space: https://huggingface.co/spaces/cbensimon/gradio-zerogpu-handshake

@cbensimon cbensimon marked this pull request as ready for review January 2, 2025 16:43
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @cbensimon!

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 8, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/client minor
@self/app minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

[ZeroGPU] Handshake-based postMessage

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

gradio/blocks.py Outdated
@@ -1303,7 +1301,6 @@ def iterate_over_children(children_list):
original_mapping[o] for o in dependency["outputs"]
]
dependency.pop("status_tracker", None)
dependency.pop("zerogpu", None)
Copy link
Member

@abidlabs abidlabs Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should leave this as we are loading old configs which may include the zerogpu key in the config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was indeed sceptical about this change because of old versions

@abidlabs abidlabs enabled auto-merge (squash) January 10, 2025 02:21
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good aside from one thing, will merge in once ci passes for the release tomorrow

@abidlabs abidlabs merged commit bb11a2a into gradio-app:main Jan 10, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants