Skip to content

Commit

Permalink
fix: Pivot table not sorting formatted numeric column properly (apach…
Browse files Browse the repository at this point in the history
…e#5709)

* fix: Pivot table not sorting formatted numeric column properly

* refactor(lint): fixed lint error

(cherry picked from commit 4121d57)
  • Loading branch information
Arpit authored and John Bodley committed Sep 12, 2018
1 parent 9bb4086 commit d4c5402
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions superset/assets/src/visualizations/pivot_table.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ function PivotTable(element, props) {
const tdText = $(this)[0].textContent;
if (!Number.isNaN(tdText) && tdText !== '') {
$(this)[0].textContent = d3format(format, tdText);
$(this).attr('data-sort', tdText);
}
});
});
Expand Down

0 comments on commit d4c5402

Please sign in to comment.