Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a theme direction #956

Merged
merged 4 commits into from
Jul 24, 2024
Merged

feat: add a theme direction #956

merged 4 commits into from
Jul 24, 2024

Conversation

LinaYahya
Copy link
Contributor

closes #955

@LinaYahya LinaYahya requested review from pyphilia and spaenleh and removed request for pyphilia and spaenleh July 17, 2024 08:01
@LinaYahya LinaYahya self-assigned this Jul 17, 2024
pyphilia
pyphilia reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would like a PR in Builder as well to make sure it does not break our main interface 😄

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LinaYahya LinaYahya requested a review from pyphilia July 23, 2024 08:14
@LinaYahya
Copy link
Contributor Author

LGTM! I would like a PR in Builder as well to make sure it does not break our main interface 😄

@pyphilia

Thanks for your comment, I did here Builder support RTL, but not very sure if we want to merge it

@pyphilia pyphilia added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit d9ed920 Jul 24, 2024
3 checks passed
@graasper graasper mentioned this pull request Jul 24, 2024
Merged
@spaenleh spaenleh deleted the 955-set-theme-direction branch July 31, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@LinaYahya LinaYahya

Labels
v4.23.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support arabic style by setting direction on theme context
2 participants
@LinaYahya @pyphilia