Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor with authorization, change current account type #1046

Merged
merged 15 commits into from
Sep 20, 2024
Merged

feat: refactor with authorization, change current account type #1046

merged 15 commits into from
Sep 20, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Sep 17, 2024 •
edited
Loading

In this PR:

  • withAuthorization -> SignedInWrapper (Component)
  • ItemLoginWrapper (Component)
  • PreventGuestWrapper (Component) - new
  • update currentMember type

We can discuss the naming.

@pyphilia pyphilia requested review from spaenleh, ReidyT and alvrba and removed request for spaenleh, ReidyT and alvrba September 17, 2024 14:54
@spaenleh spaenleh assigned spaenleh and pyphilia and unassigned spaenleh Sep 19, 2024
spaenleh
spaenleh approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! I have left a few comments.

src/itemLogin/ItemLoginAuthorization.tsx Outdated Show resolved Hide resolved
src/itemLogin/ItemLoginAuthorization.stories.tsx Outdated Show resolved Hide resolved
ReidyT
ReidyT previously requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧑‍🚀 I wonder if we should make the optional parameters of PreventGuestWrapper mandatory. What do you think (I elaborate that directly in the code review)?

src/Authorization/PreventGuestWrapper.tsx Outdated Show resolved Hide resolved
src/Authorization/PreventGuestWrapper.tsx Outdated Show resolved Hide resolved
src/Authorization/SignedInWrapper.tsx Outdated Show resolved Hide resolved
src/Authorization/PreventGuestWrapper.stories.tsx Outdated Show resolved Hide resolved
src/itemLogin/ItemLoginAuthorization.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia dismissed ReidyT’s stale review September 20, 2024 09:02

already one review

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit bfe516f Sep 20, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 20, 2024
Merged
@pyphilia pyphilia deleted the refactor-with-authorization branch September 20, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@pyphilia pyphilia

Labels
v5.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @spaenleh @ReidyT