Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): use memberId for legacy apps #1045

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(app): use memberId for legacy apps #1045

merged 2 commits into from
Sep 18, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Sep 17, 2024 •
edited
Loading

UI applies the new namenclature accountId, and itself adds a property memberId so it is compatible with legacy apps.

@pyphilia pyphilia self-assigned this Sep 17, 2024
ReidyT
ReidyT approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

spaenleh
spaenleh approved these changes Sep 18, 2024
View reviewed changes
src/items/appItemHooks.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 37791ad Sep 18, 2024
3 checks passed
@graasper graasper mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@ReidyT ReidyT ReidyT approved these changes

Assignees

@pyphilia pyphilia

Labels
v5.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @spaenleh @ReidyT