Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redesign add application ui #1188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ztlee042
Copy link
Contributor

@ztlee042 ztlee042 commented Apr 25, 2024

In this PR:

CleanShot.2024-04-30.at.11.46.23.mp4

@ztlee042 ztlee042 self-assigned this Apr 25, 2024
@ztlee042 ztlee042 marked this pull request as ready for review April 30, 2024 09:48
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those changes! I think it will really improve the creation of apps!

Some additional design comments:
I have those "margins", I think because of overflowing.

Screenshot 2024-05-01 at 11 43 26 Screenshot 2024-05-01 at 11 43 19

Also I know were not really responsive friendly, but I think it would be good to at least collapse the 2 columns into one on smaller screens.
Screenshot 2024-05-01 at 12 06 15

src/langs/en.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/main/AppCard.tsx Outdated Show resolved Hide resolved
src/components/main/AppCard.tsx Outdated Show resolved Hide resolved
@ztlee042
Copy link
Contributor Author

ztlee042 commented May 1, 2024

Hi Kim @pyphilia, I have updated the styles. Could you please check if the margin problems are still there? Thanks a lot.

@ztlee042 ztlee042 requested a review from pyphilia May 1, 2024 12:58
@ztlee042
Copy link
Contributor Author

ztlee042 commented May 2, 2024

I just had two feedback from the testing participants:

  • The search bar could stand out more. Both of them didn't notice the search bar at first look.
  • The scroll bar should be visible. They didn't realize it was a scrollable area at first look.

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

Some additional thoughts:

  • "the scrollbar should be visible" -> I think it's always visible, do you mean make it even more visible? Wouldn't that be too much?
  • Also I think the "create your own application" button is way more too visible, that's the very first thing I see in this modal. Actually it doesn't have to be that highlighted, why not just a little text next to "Need a custom solution ? " for example.

src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/item/form/AppForm.tsx Outdated Show resolved Hide resolved
src/components/main/AppCard.tsx Outdated Show resolved Hide resolved
src/components/main/AppCard.tsx Outdated Show resolved Hide resolved
@ztlee042
Copy link
Contributor Author

Thanks for the work!

Some additional thoughts:

  • "the scrollbar should be visible" -> I think it's always visible, do you mean make it even more visible? Wouldn't that be too much?
  • Also I think the "create your own application" button is way more too visible, that's the very first thing I see in this modal. Actually it doesn't have to be that highlighted, why not just a little text next to "Need a custom solution ? " for example.

For the first question, on Mac there is a setting set scrollbar invisible by default, that's why users didn't see the scrollbar by default.
I will look into the second question.

Thanks for your feedback overall!

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ztlee042 ztlee042 requested a review from pyphilia May 15, 2024 12:33
Copy link

sonarcloud bot commented Jun 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants