Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass direction to theme provider #1363

Merged
merged 3 commits into from
Jul 25, 2024
Merged

feat: pass direction to theme provider #1363

merged 3 commits into from
Jul 25, 2024

Conversation

LinaYahya
Copy link
Contributor

No description provided.

@LinaYahya LinaYahya requested a review from spaenleh July 19, 2024 08:15
@LinaYahya LinaYahya mentioned this pull request Jul 23, 2024
Merged
pyphilia
pyphilia requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, for me it's all good, just resolve conflicts and my comments, and it will be good to go! 🍁

src/components/Root.tsx Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LinaYahya LinaYahya marked this pull request as ready for review July 25, 2024 08:30
@LinaYahya LinaYahya requested a review from pyphilia July 25, 2024 09:09
@pyphilia pyphilia added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 0843cbd Jul 25, 2024
4 checks passed
@graasper graasper mentioned this pull request Jul 25, 2024
Merged
@pyphilia pyphilia deleted the arabic-view branch August 5, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@LinaYahya LinaYahya

Labels
v2.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinaYahya @pyphilia